[ 
https://issues.apache.org/jira/browse/KAFKA-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715041#comment-17715041
 ] 

Alexandre Dupriez edited comment on KAFKA-14928 at 4/21/23 2:55 PM:
--------------------------------------------------------------------

Hi Divij, thanks for reporting this. Would you have a reproduction case which 
exhibits the contention?


was (Author: adupriez):
Hi Divij, thanks for reporting this. Would you have a reproduction case which 
demonstrates the contention?

> Metrics collection contends on lock with log cleaning
> -----------------------------------------------------
>
>                 Key: KAFKA-14928
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14928
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Divij Vaidya
>            Assignee: Divij Vaidya
>            Priority: Major
>             Fix For: 3.6.0
>
>
> In LogCleanerManager.scala, calculation of a metric requires a lock [1]. This 
> same lock is required by core log cleaner functionality such as 
> "grabFilthiestCompactedLog". This might lead to a situation where metric 
> calculation holding the lock for an extended period of time may affect the 
> core functionality of log cleaning.
> This outcome of this task is to prevent expensive metric calculation from 
> blocking log cleaning/compaction activity.
> [1] 
> https://github.com/apache/kafka/blob/dd63d88ac3ea7a9a55a6dacf9c5473e939322a55/core/src/main/scala/kafka/log/LogCleanerManager.scala#L102



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to