mimaison commented on PR #13259: URL: https://github.com/apache/kafka/pull/13259#issuecomment-1519845506
Thanks for the updates! There's a spotbugs failure: ``` Bug type EQ_DOESNT_OVERRIDE_EQUALS In class org.apache.kafka.connect.runtime.InternalSinkRecord EQ_DOESNT_OVERRIDE_EQUALS: Class doesn't override equals in superclass This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org