showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176027142
########## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ########## @@ -277,64 +312,65 @@ CompletableFuture<Void> enqueueMetadataChangeEventWithFuture( public void testOnlySendNeededRPCsToBrokers() throws Exception { CountingMetadataPropagator metadataPropagator = new CountingMetadataPropagator(); CapturingMigrationClient migrationClient = new CapturingMigrationClient(new HashSet<>(Arrays.asList(1, 2, 3))); - KRaftMigrationDriver driver = new KRaftMigrationDriver( + try (KRaftMigrationDriver driver = new KRaftMigrationDriver( Review Comment: Using try with resource. Nothing else changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org