jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176590727
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ########## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.consumer.ConsumerGroupMember; +import org.apache.kafka.coordinator.group.consumer.TopicMetadata; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupCurrentMemberAssignmentKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupCurrentMemberAssignmentValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupPartitionMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupPartitionMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMetadataValue; +import org.apache.kafka.server.common.ApiMessageAndVersion; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class contains helper methods to create records stored in + * the __consumer_offsets topic. + */ +public class RecordHelpers { + private RecordHelpers() {} + + /** + * Creates a ConsumerGroupMemberMetadata record. + * + * @param groupId The consumer group id. + * @param member The consumer group member. + * @return The record. + */ + public static Record newMemberSubscriptionRecord( Review Comment: can we use `newMemberMetadataRecord`? i feel it's confusing we're using two terms to refer to the same thing. conversely, why can't we name the record `ConsumerGroupMemberSubscriptionKey/Value`? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ########## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.consumer.ConsumerGroupMember; +import org.apache.kafka.coordinator.group.consumer.TopicMetadata; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupCurrentMemberAssignmentKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupCurrentMemberAssignmentValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupPartitionMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupPartitionMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMetadataValue; +import org.apache.kafka.server.common.ApiMessageAndVersion; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class contains helper methods to create records stored in + * the __consumer_offsets topic. + */ +public class RecordHelpers { + private RecordHelpers() {} + + /** + * Creates a ConsumerGroupMemberMetadata record. + * + * @param groupId The consumer group id. + * @param member The consumer group member. + * @return The record. + */ + public static Record newMemberSubscriptionRecord( + String groupId, + ConsumerGroupMember member + ) { + return new Record( + new ApiMessageAndVersion( + new ConsumerGroupMemberMetadataKey() + .setGroupId(groupId) + .setMemberId(member.memberId()), + (short) 5 + ), + new ApiMessageAndVersion( + new ConsumerGroupMemberMetadataValue() + .setRackId(member.rackId()) + .setInstanceId(member.instanceId()) + .setClientId(member.clientId()) + .setClientHost(member.clientHost()) + .setSubscribedTopicNames(member.subscribedTopicNames()) + .setSubscribedTopicRegex(member.subscribedTopicRegex()) + .setServerAssignor(member.serverAssignorName().orElse(null)) + .setRebalanceTimeoutMs(member.rebalanceTimeoutMs()) + .setAssignors(member.clientAssignors().stream().map(assignorState -> + new ConsumerGroupMemberMetadataValue.Assignor() + .setName(assignorState.name()) + .setReason(assignorState.reason()) + .setMinimumVersion(assignorState.minimumVersion()) + .setMaximumVersion(assignorState.maximumVersion()) + .setVersion(assignorState.metadata().version()) + .setMetadata(assignorState.metadata().metadata().array()) + ).collect(Collectors.toList())), + (short) 0 + ) + ); + } + + /** + * Creates a ConsumerGroupMemberMetadata tombstone. + * + * @param groupId The consumer group id. + * @param memberId The consumer group member id. + * @return The record. + */ + public static Record newMemberSubscriptionTombstoneRecord( + String groupId, + String memberId + ) { + return new Record( + new ApiMessageAndVersion( + new ConsumerGroupMemberMetadataKey() + .setGroupId(groupId) + .setMemberId(memberId), + (short) 5 + ), + null // Tombstone. + ); + } + + /** + * Creates a ConsumerGroupPartitionMetadata record. + * + * @param groupId The consumer group id. + * @param newSubscriptionMetadata The subscription metadata. + * @return The record. + */ + public static Record newGroupSubscriptionMetadataRecord( Review Comment: similar to the question above, can we unify the naming? also, have we considered using `ConsumerGroupTopicMetadataKey/Value`? The existing name suggests that the record should be containing partition-level information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
