[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

[via GitHub]

bmscomp commented on code in PR #13627:
URL: https://github.com/apache/kafka/pull/13627#discussion_r1178371488


##########
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##########
@@ -143,12 +143,6 @@ public int compareTo(Uuid other) {
             return 1;

Review Comment:
   Still there is another way to implement the `compareTo` method, and by the 
way `compare`  can be a pretty name also for the method, and it will keep the 
same style of the compare method name in `Long` 
   
    
          if (mostSignificantBits == other.mostSignificantBits)
               return Long.compare(leastSignificantBits, 
other.leastSignificantBits);
           return Long.compare(mostSignificantBits, other.mostSignificantBits);
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org