kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1178509941
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -424,6 +477,11 @@ ProducerIdAndEpoch producerIdAndEpoch() {
}
synchronized public void maybeUpdateProducerIdAndEpoch(TopicPartition
topicPartition) {
+ if (hasFatalError()) {
Review Comment:
@urbandan LMK if you think this is correct or not. The
`hasStaleProducerIdAndEpoch` does mutate some internal state which I'm
_assuming_ we want to prevent if we're in a fatal state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
