[GitHub] [kafka] kirktrue commented on a diff in pull request #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

[via GitHub]

kirktrue commented on code in PR #13640:
URL: https://github.com/apache/kafka/pull/13640#discussion_r1179784672


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchConfig.java:
##########
@@ -66,8 +67,7 @@
     final int maxPollRecords;
     final boolean checkCrcs;
     final String clientRackId;
-    final Deserializer<K> keyDeserializer;
-    final Deserializer<V> valueDeserializer;
+    final Deserializers<K, V> deserializers;
     final IsolationLevel isolationLevel;
 
     public FetchConfig(int minBytes,

Review Comment:
   No, it's really only called by `CompletedFetch`. It's just that we have to 
pass the two deserializers around through multiple layers of code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org