dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1179969167
########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ########## @@ -0,0 +1,574 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.coordinator.group.assignor; + +import org.apache.kafka.common.Uuid; + +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class RangeAssignorTest { + private final RangeAssignor assignor = new RangeAssignor(); + private final Uuid topic1Uuid = Uuid.randomUuid(); + private final Uuid topic2Uuid = Uuid.randomUuid(); + private final Uuid topic3Uuid = Uuid.randomUuid(); + private final String consumerA = "A"; + private final String consumerB = "B"; + private final String consumerC = "C"; + + @Test + public void testOneConsumerNoTopic() { + Map<Uuid, AssignmentTopicMetadata> topics = Collections.singletonMap(topic1Uuid, new AssignmentTopicMetadata(3)); + Map<String, AssignmentMemberSpec> members = Collections.singletonMap( + consumerA, + new AssignmentMemberSpec( + Optional.empty(), + Optional.empty(), + Collections.emptyList(), + Collections.emptyMap()) + ); + + AssignmentSpec assignmentSpec = new AssignmentSpec(members, topics); + GroupAssignment groupAssignment = assignor.assign(assignmentSpec); + + assertTrue(groupAssignment.members().isEmpty()); + } + + @Test + public void testOneConsumerNonExistentTopic() { + Map<Uuid, AssignmentTopicMetadata> topics = Collections.singletonMap(topic1Uuid, new AssignmentTopicMetadata(3)); + Map<String, AssignmentMemberSpec> members = Collections.singletonMap( + consumerA, + new AssignmentMemberSpec( + Optional.empty(), + Optional.empty(), + Collections.singletonList(topic2Uuid), + Collections.emptyMap()) + ); + + AssignmentSpec assignmentSpec = new AssignmentSpec(members, topics); + GroupAssignment groupAssignment = assignor.assign(assignmentSpec); + + assertTrue(groupAssignment.members().isEmpty()); + } + + @Test + public void testFirstAssignmentTwoConsumersTwoTopicsSameSubscriptions() { + Map<Uuid, AssignmentTopicMetadata> topics = new HashMap<>(); + topics.put(topic1Uuid, new AssignmentTopicMetadata(3)); + topics.put(topic3Uuid, new AssignmentTopicMetadata(2)); + + Map<String, AssignmentMemberSpec> members = new HashMap<>(); + // Initial Subscriptions are: A -> T1, T3 | B -> T1, T3 + + members.put(consumerA, new AssignmentMemberSpec( + Optional.empty(), + Optional.empty(), + Arrays.asList(topic1Uuid, topic3Uuid), + Collections.emptyMap()) + ); + + members.put(consumerB, new AssignmentMemberSpec( + Optional.empty(), + Optional.empty(), + Arrays.asList(topic1Uuid, topic3Uuid), + Collections.emptyMap()) + ); + + AssignmentSpec assignmentSpec = new AssignmentSpec(members, topics); + GroupAssignment computedAssignment = assignor.assign(assignmentSpec); + + Map<Uuid, Set<Set<Integer>>> expectedAssignment = new HashMap<>(); + // Topic 1 Partitions Assignment + mkAssignment(expectedAssignment, topic1Uuid, Arrays.asList(0, 1)); + mkAssignment(expectedAssignment, topic1Uuid, Collections.singleton(2)); + // Topic 3 Partitions Assignment + mkAssignment(expectedAssignment, topic3Uuid, Collections.singleton(0)); + mkAssignment(expectedAssignment, topic3Uuid, Collections.singleton(1)); + + assertAssignment(expectedAssignment, computedAssignment); Review Comment: Yeah, sorry for this. I only thought about it when I raised this comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
