machi1990 commented on code in PR #13623:
URL: https://github.com/apache/kafka/pull/13623#discussion_r1182849704
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig,
*/
def shutdown(): Unit = {
info("Shutting down the log cleaner.")
- cleaners.foreach(_.shutdown())
- cleaners.clear()
+ try {
+ cleaners.foreach(_.shutdown())
+ cleaners.clear()
+ } finally {
+ remoteMetrics()
+ }
+ }
+
+ def remoteMetrics(): Unit = {
+ metricsGroup.removeMetric("max-buffer-utilization-percent")
+ metricsGroup.removeMetric("cleaner-recopy-percent")
+ metricsGroup.removeMetric("max-clean-time-secs")
+ metricsGroup.removeMetric("max-compaction-delay-secs")
+ metricsGroup.removeMetric("DeadThreadCount")
Review Comment:
I've created https://issues.apache.org/jira/browse/KAFKA-14959, I'll assign
it to myself and give it a stab at some point end this week or early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
