splett2 commented on code in PR #13655:
URL: https://github.com/apache/kafka/pull/13655#discussion_r1183105854
##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -609,7 +609,10 @@ class DynamicBrokerConfigTest {
val zkClient: KafkaZkClient = mock(classOf[KafkaZkClient])
when(zkClient.getEntityConfigs(anyString(), anyString())).thenReturn(new
java.util.Properties())
- val oldConfig = KafkaConfig.fromProps(TestUtils.createBrokerConfig(0,
TestUtils.MockZkConnect, port = 9092))
+ val initialProps = TestUtils.createBrokerConfig(0,
TestUtils.MockZkConnect, port = 9092)
Review Comment:
The `TestDynamicThreadPool` mock class expects the various thread count
props to be initialized to the defaults. So I am removing the static overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
