[GitHub] [kafka] mjsax commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

[via GitHub]

mjsax commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1185618918


##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -106,7 +106,11 @@ private static class ValueList {
         }
 
         int next() {
-            return (index < values.length) ? values[index++] : -1;
+            final int v = values[index++];
+            if (index >= values.length) {
+                index = 0;
+            }

Review Comment:
   Seems the comment is outdated. The custom TS-extractor was removed years 
ago: 
https://github.com/apache/kafka/commit/52e397962b624f3c881b6f99e71c94da32cf6a33
   
   Let me delete the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org