philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1190097766
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long now) {
}
}
+ private boolean waitForPendingAsyncCommits(Timer timer) {
+ if (inFlightAsyncCommits.get() == 0) {
+ return true;
+ }
+
+ do {
+ ensureCoordinatorReady(timer);
Review Comment:
commitOffsetSync is already attempting to connect to the coordinator, so it
might make more sense to remove this, and move the` if (offset.isEmpty()) {...}
` below `coordinatorUnknownAndUnreadySync`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
