dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191653253


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java:
##########
@@ -399,8 +403,12 @@ public void testNewCurrentAssignmentTombstoneRecord() {
         ));
     }
 
-    @Test
-    public void testNewGroupMetadataRecord() {
+    @ParameterizedTest
+    @MethodSource("metadataToExpectedGroupMetadataValue")

Review Comment:
   Ah. I see. I missed the version part. We can keep it as it is but could we 
move the method to just before this test? It is easier to read them together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to