[GitHub] [kafka] soarez commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

[via GitHub]

soarez commented on code in PR #13558:
URL: https://github.com/apache/kafka/pull/13558#discussion_r1198804390


##########
core/src/main/scala/kafka/zk/KafkaZkClient.scala:
##########
@@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: 
ZooKeeperClient, isSecure: Boo
   }
 
   private class CheckedEphemeral(path: String, data: Array[Byte]) extends 
Logging {
+    private var attempt = 0
+    private val maxAttempt = 5
+    private val backoffMs = 1000

Review Comment:
   I wonder if it would make sense to have the interval between retries be 
defined as: `(zkSessionTimeout + margin) / maxAttempts`? Where `margin` could 
be a small fixed delta, e.g. one second, and `zkSessionTimeout` is taken from 
the Kafka configuration for `"zookeeper.session.timeout.ms"`. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org