satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1184873142
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -670,6 +875,14 @@ public void close() {
} catch (InterruptedException e) {
// ignore
}
+ remoteStorageReaderThreadPool.shutdownNow();
+ //waits for 2 mins to terminate the current tasks
+ try {
+ remoteStorageReaderThreadPool.awaitTermination(2,
TimeUnit.MINUTES);
Review Comment:
It does not require that to be completed in 5 mins.
`lifecycleManager.controlledShutdownFuture` is more about processing the
controlled shutdown event to the controller for that broker. It will wait for 5
mins before proceeding with other sequence of actions. But that will not get
affected because of the code introduced here.
Logging subsystem handles unclean shutdown for log segments and it would
have been already finished before RemoteLogManager is closed. So, they will not
get affected because of this timeout. But we can have a short duration here
like 10 secs, we can revisit introducing a config if it is really needed for
closing the remote log subsystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
