[ 
https://issues.apache.org/jira/browse/KAFKA-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463952#comment-16463952
 ] 

ASF GitHub Bot commented on KAFKA-6864:
---------------------------------------

makubi opened a new pull request #4969: KAFKA-6864: Pass null key and value to 
deserializer
URL: https://github.com/apache/kafka/pull/4969
 
 
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> null is not passed to keyDeserialzer and valueDeserializer in Fetcher
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-6864
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6864
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer
>    Affects Versions: 1.1.0
>            Reporter: Mathias Kub
>            Priority: Major
>
> Hi,
> currently null values are not passed to the keyDeserializer and 
> valueDeserializer in the Fetcher class. This prevents custom deserialization 
> of null values.
> The Deserializer JavaDoc says
> {code:java}
> /**
> * Deserialize a record value from a byte array into a value or object.
> * @param topic topic associated with the data
> * @param data serialized bytes; may be null; implementations are recommended 
> to handle null by returning a value or null rather than throwing an exception.
> * @return deserialized typed data; may be null
> */
> T deserialize(String topic, byte[] data);{code}
> so as for my understanding, null values should be passed to it.
>  
> Thanks,
> Mathias



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to