divijvaidya commented on PR #13746: URL: https://github.com/apache/kafka/pull/13746#issuecomment-1560684188
Hey @sanjanagoyal Thank you for your first contribution to the project. 1. Would you please add a unit test that fails prior to this change and succeeds afterwards? Apart from ensuring that this bug doesn't occur again, it also helps the reviewers understand the nature of the bug and the fix. 2. I would also suggest to open a JIRA describing the bug and associate this PR with the JIRA. You can find further instructions on how to do so at https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
