urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1204028973
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -626,12 +704,14 @@ public synchronized void
maybeTransitionToErrorState(RuntimeException exception)
if (canBumpEpoch() && !isCompleting()) {
epochBumpRequired = true;
}
- transitionToAbortableError(exception);
+ transitionToAbortableError(exception,
invalidStateDetectionStrategy);
}
}
-
- synchronized void handleFailedBatch(ProducerBatch batch, RuntimeException
exception, boolean adjustSequenceNumbers) {
- maybeTransitionToErrorState(exception);
+ synchronized void handleFailedBatch(ProducerBatch batch,
Review Comment:
is this ever called with InvalidStateDetectionStrategy.FOREGROUND?
if not, we might not need the extra parameter, and always use BACKGROUND
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
