C0urante commented on code in PR #13334:
URL: https://github.com/apache/kafka/pull/13334#discussion_r1205854894
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##########
@@ -188,11 +191,34 @@ public static boolean isClassFile(Path path) {
return path.toString().toLowerCase(Locale.ROOT).endsWith(".class");
}
- public static List<Path> pluginLocations(Path topPath) throws IOException {
+ public static List<Path> pluginLocations(String pluginPath) {
+ if (pluginPath == null) {
+ return Collections.emptyList();
+ }
+ String[] pluginPathElements =
COMMA_WITH_WHITESPACE.split(pluginPath.trim(), -1);
+ List<Path> pluginLocations = new ArrayList<>();
+ for (String path : pluginPathElements) {
+ try {
+ Path pluginPathElement = Paths.get(path).toAbsolutePath();
+ // Currently 'plugin.paths' property is a list of top-level
directories
+ // containing plugins
+ if (Files.isDirectory(pluginPathElement)) {
+ pluginLocations.addAll(pluginLocations(pluginPathElement));
+ } else if (isArchive(pluginPathElement)) {
+ pluginLocations.add(pluginPathElement);
+ }
Review Comment:
Do we also want to include the catch block for `InvalidPathException` here,
which matches the [logic on
trunk](https://github.com/apache/kafka/blob/dc00832b965c29fbbb4148cc680fadfc3f28642a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java#L266-L267)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
