cmccabe commented on code in PR #13767: URL: https://github.com/apache/kafka/pull/13767#discussion_r1207234024
########## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ########## @@ -194,23 +195,44 @@ void handleTopicsDelta(Function<Uuid, String> deletedTopicNameResolver, TopicsDe } void handleConfigsSnapshot(ConfigurationsImage configsImage) { - Set<ConfigResource> brokersToUpdate = new HashSet<>(); + Set<ConfigResource> newResources = new HashSet<>(configsImage.resourceData().keySet()) Review Comment: I think we should throw an exception if we get a ConfigResource whose type isn't BROKER or TOPIC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org