jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207333185
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -671,6 +671,7 @@ class ReplicaManager(val config: KafkaConfig,
val sTime = time.milliseconds
val transactionalProducerIds = mutable.HashSet[Long]()
+ var verificationState: Optional[VerificationState] = Optional.empty()
Review Comment:
I don't think we would get a new one. We only need one per transaction
right?
So either we succeed and no longer need to worry about the verification, or
the partition is retried and get the same verification object from the first
time.
We do have a test with multiple partitions but I would have to check if it
also checks the verification state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
