hachikuji commented on code in PR #13780:
URL: https://github.com/apache/kafka/pull/13780#discussion_r1212038808
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -220,13 +220,24 @@ private boolean isValidNewLeader(int replica) {
private void tryElection(PartitionChangeRecord record) {
ElectionResult electionResult = electLeader();
if (electionResult.node != partition.leader) {
- log.debug(
- "Setting new leader for topicId {}, partition {} to {} using
{} election",
- topicId,
- partitionId,
- electionResult.node,
- electionResult.unclean ? "an unclean" : "a clean"
- );
+ // generating log messages for partition elections can get
expensive on large clusters,
+ // so only log clean elections at TRACE level;
+ // log unclean elections at WARN level since doing so can lead to
data loss.
+ if (electionResult.unclean) {
+ log.warn(
Review Comment:
How about INFO level? Unclean election "expected behavior" if it is enabled
or requested specifically.
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -220,13 +220,24 @@ private boolean isValidNewLeader(int replica) {
private void tryElection(PartitionChangeRecord record) {
ElectionResult electionResult = electLeader();
if (electionResult.node != partition.leader) {
- log.debug(
- "Setting new leader for topicId {}, partition {} to {} using
{} election",
- topicId,
- partitionId,
- electionResult.node,
- electionResult.unclean ? "an unclean" : "a clean"
- );
+ // generating log messages for partition elections can get
expensive on large clusters,
+ // so only log clean elections at TRACE level;
+ // log unclean elections at WARN level since doing so can lead to
data loss.
+ if (electionResult.unclean) {
+ log.warn(
Review Comment:
How about INFO level? Unclean election is "expected behavior" if it is
enabled or requested specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
