dajac commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1214154053
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -105,6 +105,8 @@ public final class ConsumerCoordinator extends
AbstractCoordinator {
private final boolean autoCommitEnabled;
private final int autoCommitIntervalMs;
private final ConsumerInterceptors<?, ?> interceptors;
+ // package private for testing
+ final AtomicInteger inFlightAsyncCommits;
private final AtomicInteger pendingAsyncCommits;
Review Comment:
Could we add a comment for these two variables? I think that we were all
confused by them while looking at this PR so adding clarifying comments would
make sense here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
