jsancio commented on PR #13765: URL: https://github.com/apache/kafka/pull/13765#issuecomment-1573978281
> 1. We change leader epoch when a replica is removed and shrinks the ISR (without a leader-re-election). Is that correct? Is yes, then should we also removing the logic to increment the epoch in such situations to keep the definition of leader epoch consistent? Yes. That is what the change to `PartittionChangeBuilder` does. Can you point me to what code exactly are you referring to? > 2. Is a similar change required for Zk code path? We need to keep the old behavior in ZK deployments because the ZK controller doesn't implement KIP-841 which is required for this fix to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
