[GitHub] [kafka] C0urante commented on a diff in pull request #13750: MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method

[via GitHub]

C0urante commented on code in PR #13750:
URL: https://github.com/apache/kafka/pull/13750#discussion_r1218206159


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1104,7 +1104,9 @@ public void stopConnector(final String connName, final 
Callback<Void> callback)
                     writeTaskConfigs(connName, Collections.emptyList());
                     configBackingStore.putTargetState(connName, 
TargetState.STOPPED);
                     // Force a read of the new target state for the connector
-                    refreshConfigSnapshot(workerSyncTimeoutMs);
+                    if (!refreshConfigSnapshot(workerSyncTimeoutMs)) {
+                        throw new ConnectException("Failed to read to end of 
config topic");

Review Comment:
   Yep, exactly! Again though, still not sure if this is worth 
implementing--just figured it might be worth sharing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org