vamossagar12 commented on code in PR #13726: URL: https://github.com/apache/kafka/pull/13726#discussion_r1218211612
########## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java: ########## @@ -458,13 +458,8 @@ boolean sendRecords() { } protected List<SourceRecord> poll() throws InterruptedException { - try { - return task.poll(); - } catch (RetriableException | org.apache.kafka.common.errors.RetriableException e) { - log.warn("{} failed to poll records from SourceTask. Will retry operation.", this, e); - // Do nothing. Let the framework poll whenever it's ready. - return null; - } + retryWithToleranceOperator.reset(); + return retryWithToleranceOperator.execute(task::poll, Stage.TASK_POLL, this.getClass()); Review Comment: Not sure why would the task not fail. As already explained [here](https://github.com/apache/kafka/pull/13726#discussion_r1218190316), if a non retriable exception is thrown, then based on this condition https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java#L225-L233 a ConnectException would be thrown or a null value is returned. It depends if the exception thrown from the specific operation is assignable or not and also on the tolerance limits. So, if the tolerance limit is none, then it fails. Also, if it's a retriableException and the deadline exceeds, then a null value is returned. The current code [here](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java#L356) already handles null values returned from poll(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org