cmccabe commented on code in PR #13703:
URL: https://github.com/apache/kafka/pull/13703#discussion_r1218712388
##########
metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java:
##########
@@ -64,12 +66,44 @@
* completed, which is another reason the prepare / complete callbacks are
needed.
*/
public class AclControlManager {
+ static class Builder {
+ private LogContext logContext = null;
+ private SnapshotRegistry snapshotRegistry = null;
+ private Optional<ClusterMetadataAuthorizer> authorizer =
Optional.empty();
+
+ Builder setLogContext(LogContext logContext) {
+ this.logContext = logContext;
+ return this;
+ }
+
+ Builder setSnapshotRegistry(SnapshotRegistry snapshotRegistry) {
+ this.snapshotRegistry = snapshotRegistry;
+ return this;
+ }
+
+ Builder
setClusterMetadataAuthorizer(Optional<ClusterMetadataAuthorizer> authorizer) {
+ this.authorizer = authorizer;
+ return this;
+ }
+
+ AclControlManager build() {
+ if (logContext == null) logContext = new LogContext();
Review Comment:
@rondagostino is correct that the defaults here do not get used except in
unit tests.
In general we want `[QuorumController id=1] ` to appear before every quorum
controller log message. The class name (AclControlManager or whatever) actually
gets logged separately at the end of the line, when using the typical log4j
setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
