jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1222035271
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java:
##########
@@ -16,21 +16,23 @@
*/
package org.apache.kafka.coordinator.group.runtime;
+import org.apache.kafka.common.TopicPartition;
+
/**
* The base event type used by all events processed in the
* coordinator runtime.
*/
-public interface CoordinatorEvent extends EventAccumulator.Event<Integer> {
+public interface CoordinatorEvent extends
EventAccumulator.Event<TopicPartition> {
/**
- * Runs the event.
+ * Executes the event.
*/
void run();
/**
* Completes the event with the provided exception.
*
- * @param exception An exception to complete the event with.
+ * @param exception An exception if the processing of the event failed or
null.
Review Comment:
nit: maybe "An exception if the processing of the event failed or null
otherwise"
I read this as exception if the event failed or was null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
