cadonna commented on code in PR #13830: URL: https://github.com/apache/kafka/pull/13830#discussion_r1226628763
########## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueChangeBuffer.java: ########## @@ -418,7 +418,7 @@ public void evictWhile(final Supplier<Boolean> predicate, changelogTopic, new Change<>(bufferValue.newValue(), bufferValue.oldValue()) ); - callback.accept(new Eviction<>(key, value, bufferValue.context())); + callback.accept(new Eviction<K, Change<V>>(key, value, bufferValue.context())); Review Comment: Do you need the type parameters here? My IntelliJ says no, but maybe there is reason that my IntelliJ does not know. Would not be the first time something like this happens. ########## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueChangeBuffer.java: ########## @@ -65,7 +65,7 @@ import static org.apache.kafka.streams.state.internals.TimeOrderedKeyValueBufferChangelogDeserializationHelper.deserializeV3; import static org.apache.kafka.streams.state.internals.TimeOrderedKeyValueBufferChangelogDeserializationHelper.duckTypeV2; -public final class InMemoryTimeOrderedKeyValueBuffer<K, V> implements TimeOrderedKeyValueBuffer<K, V> { +public final class InMemoryTimeOrderedKeyValueChangeBuffer<K, V, T> implements TimeOrderedKeyValueBuffer<K, V, Change<V>> { Review Comment: Do you need parameter `T` in `InMemoryTimeOrderedKeyValueChangeBuffer<K, V, T>`? It is not used anywhere. I think removing it will reduce the changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org