dimitarndimitrov opened a new pull request, #13856: URL: https://github.com/apache/kafka/pull/13856
The Java rewrite is kept relatively close to the Scala original to minimize potential newly introduced bugs and to make reviewing simpler. The following details might be of note: - The `Logging` trait moved to `InterBrokerSendThread` with the rewrite of `ShutdownableThread` has been similarly moved to any subclasses that currently use it. `InterBrokerSendThread`'s own logging has been made to use `ShutdownableThread`'s logger which mimics the prefix/log identifier that the trait provided. - The case `RequestAndCompletionHandler` class has been made a separate POJO class and the internal-use `UnsentRequests` class has been kept as a static nested class. - The relatively commonly used but internal (not part of the public API) clients classes that `InterBrokerSendThread` relies on have been allowlisted in the server-common import control. - The accompanying test class has also been moved and rewritten with one new test added and most of the pre-existing tests made stricter. - The main abstract method of `InterBrokerSendThread` - `generateRequests()` - now returns a Java collection so in the initial draft `asScala` has been generously sprinkled around its usages. I'll further look into whether there's something more preferable for that. The local test run after the changes ended with _7661 tests completed, 2 failed, 3 skipped_ and the failures being seemingly unrelated and not in server-common or core. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
