tombentley commented on code in PR #13862: URL: https://github.com/apache/kafka/pull/13862#discussion_r1232343003
########## docs/streams/quickstart.html: ########## @@ -91,8 +91,8 @@ <h4><a id="quickstart_streams_download" href="#quickstart_streams_download">Step <a href="https://www.apache.org/dyn/closer.cgi?path=/kafka/{{fullDotVersion}}/kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz"; title="Kafka downloads">Download</a> the {{fullDotVersion}} release and un-tar it. Note that there are multiple downloadable Scala versions and we choose to use the recommended version ({{scalaVersion}}) here: -<pre class="line-numbers"><code class="language-bash">> tar -xzf kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz -> cd kafka_{{scalaVersion}}-{{fullDotVersion}}</code></pre> + <pre class="line-numbers"><code class="language-bash">$ tar -xzf kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz Review Comment: Do we need the initial two spaces? ########## docs/quickstart.html: ########## @@ -215,19 +215,17 @@ <h4 class="anchor-heading"> Edit the <code class="language-bash">config/connect-standalone.properties</code> file, add or change the <code>plugin.path</code> configuration property match the following, and save the file: </p> - <pre class="brush: bash;"> -> echo "plugin.path=libs/connect-file-{{fullDotVersion}}.jar"</pre> + <pre class="line-numbers"><code class="language-bash">$ echo "plugin.path=libs/connect-file-{{fullDotVersion}}.jar"</code></pre> Review Comment: ```suggestion <pre class="line-numbers"><code class="language-bash">$ echo "plugin.path=libs/connect-file-{{fullDotVersion}}.jar" >> config/connect-standalone.properties</code></pre> ``` ########## docs/quickstart.html: ########## @@ -215,19 +215,17 @@ <h4 class="anchor-heading"> Edit the <code class="language-bash">config/connect-standalone.properties</code> file, add or change the <code>plugin.path</code> configuration property match the following, and save the file: Review Comment: We don't actually mean it "should match the following" if _the following_ is some bash commands. ```suggestion Edit the <code class="language-bash">config/connect-standalone.properties</code> file, adding or changing the <code>plugin.path</code> configuration property to include <code>libs/connect-file-{{fullDotVersion}}.jar</code> and save the file. Alternatively, in your terminal session you can use the following command: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
