[
https://issues.apache.org/jira/browse/KAFKA-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469557#comment-16469557
]
ASF GitHub Bot commented on KAFKA-6299:
---------------------------------------
hachikuji opened a new pull request #4989: MINOR: A few small cleanups from
KAFKA-6299
URL: https://github.com/apache/kafka/pull/4989
Use local fields in `AdminClientRunnable` to avoid the need to pass the
collections as method parameters and fix warnings about invalid javadoc tags.
Also use the `internals` package name for `AdminMetadataManager` for
consistency with `consumer.internals` and `producer.internals`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix AdminClient error handling when metadata changes
> ----------------------------------------------------
>
> Key: KAFKA-6299
> URL: https://issues.apache.org/jira/browse/KAFKA-6299
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
> Priority: Major
> Fix For: 2.0.0
>
>
> * AdminClient should only call Metadata#requestUpdate when needed.
> * AdminClient should retry requests for which the controller has changed.
> * Fix an issue where AdminClient requests might not get a security exception,
> even when a metadata fetch fails with an authorization exception.
> * Fix a possible issue where AdminClient might leak a socket after the
> timeout expires on a hard close, if a very narrow race condition is hit
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
