divijvaidya commented on code in PR #13700:
URL: https://github.com/apache/kafka/pull/13700#discussion_r1234166769
##########
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##########
@@ -574,6 +574,7 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
def shutdown(): Unit = {
initiateShutdown()
throttledChannelReaper.awaitShutdown()
+ metrics.removeSensor(delayQueueSensor.name())
Review Comment:
in a finally block please.
##########
core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala:
##########
@@ -92,4 +91,9 @@ class ClientRequestQuotaManager(private val config:
ClientQuotaManagerConfig,
private def nanosToPercentage(nanos: Long): Double =
nanos * ClientRequestQuotaManager.NanosToPercentagePerSecond
+
+ override def shutdown(): Unit = {
+ super.shutdown()
+ metrics.removeSensor(exemptSensor.name())
Review Comment:
same. in a finally block please.
##########
core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala:
##########
@@ -28,13 +28,12 @@ import org.apache.kafka.server.quota.ClientQuotaCallback
import scala.jdk.CollectionConverters._
object ClientRequestQuotaManager {
- val QuotaRequestPercentDefault = Int.MaxValue.toDouble
Review Comment:
please investigate why do we have this unused variable. Asking because it
could be a bug where we want to use this but are not using this,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
