jolshan commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235803368
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock
import org.mockito.stubbing.Answer
import org.mockito.{ArgumentCaptor, ArgumentMatchers}
import org.mockito.ArgumentMatchers.{any, anyInt, anyMap, anySet, anyString}
-import org.mockito.Mockito.{doReturn, mock, mockConstruction, never, reset,
times, verify, verifyNoMoreInteractions, when}
+import org.mockito.Mockito.{doReturn, mock, mockConstruction, never, reset,
spy, times, verify, verifyNoMoreInteractions, when}
import scala.collection.{Map, Seq, mutable}
import scala.compat.java8.OptionConverters.RichOptionForJava8
import scala.jdk.CollectionConverters._
class ReplicaManagerTest {
- val topic = "test-topic"
- val topicId = Uuid.randomUuid()
- val topicIds = scala.Predef.Map("test-topic" -> topicId)
- val topicNames = scala.Predef.Map(topicId -> "test-topic")
- val time = new MockTime
- val scheduler = new MockScheduler(time)
- val metrics = new Metrics
- var alterPartitionManager: AlterPartitionManager = _
- var config: KafkaConfig = _
- var quotaManager: QuotaManagers = _
- var mockRemoteLogManager: RemoteLogManager = _
+ private val topic = "test-topic"
+ private val topicId: Uuid = Uuid.randomUuid()
Review Comment:
do we want to keep annotation now that it's private 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
