ijuma commented on code in PR #12948:
URL: https://github.com/apache/kafka/pull/12948#discussion_r1242309422
##########
clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java:
##########
@@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException {
// Skip bytes stored in intermediate buffer first
int avail = count - pos;
- long bytesSkipped = (avail < remaining) ? avail : remaining;
+ int bytesSkipped = Math.min(avail, (int) remaining);
Review Comment:
Can you please explain an example where these two variants would have a
different result given that `avail` is a positive int?
##########
clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java:
##########
@@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException {
// Skip bytes stored in intermediate buffer first
int avail = count - pos;
- long bytesSkipped = (avail < remaining) ? avail : remaining;
+ int bytesSkipped = Math.min(avail, (int) remaining);
Review Comment:
Can you please share an example where these two variants would have a
different result given that `avail` is a positive int?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
