jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1242874939
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig,
client: NetworkClient, time
private val inflightNodes = mutable.HashSet[Node]()
private val nodesToTransactions = mutable.Map[Node,
TransactionDataAndCallbacks]()
+ private val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ val verificationFailureRate =
metricsGroup.newMeter("VerificationFailureRate", "failures", TimeUnit.SECONDS)
Review Comment:
What is the version if we don't send the request. I think this makes sense
on api specific metrics but maybe not the ones for the manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
