gharris1727 commented on code in PR #13821:
URL: https://github.com/apache/kafka/pull/13821#discussion_r1242974877
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java:
##########
@@ -104,6 +81,33 @@ public DelegatingClassLoader(List<Path> pluginLocations) {
this(pluginLocations, DelegatingClassLoader.class.getClassLoader());
}
+ public Set<PluginSource> sources() {
Review Comment:
The refactor was just a little bit more involved (as I had to figure out a
new mocking strategy for newPluginClassLoader) but I think it's better now. I
like the static implementation, and I really like how empty the DCL class is
now.
I'm not sure exactly where to put the function though, and just stuffed it
into PluginUtils for now. Do you think this is more appropriate somewhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
