wcarlson5 commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1244729657
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java:
##########
@@ -189,7 +221,22 @@ public Joined<K, V, VO> withOtherValueSerde(final
Serde<VO> otherValueSerde) {
*/
@Override
public Joined<K, V, VO> withName(final String name) {
- return new Joined<>(keySerde, valueSerde, otherValueSerde, name);
+ return new Joined<>(keySerde, valueSerde, otherValueSerde, name,
gracePeriod);
+ }
+
+ /**
+ * Set the grace period on the stream side of the join. Records will enter
a buffer before being processed. Out of order records in the grace period will
be processed in timestamp order. Late records, out of the grace period, will be
executed right as they come in, if it is past the table history retention this
could result in joins on the wrong version or a null join. Long gaps in stream
side arriving records will cause records to be delayed in processing, even
resulting in be processed out of the grace period window.
Review Comment:
updated and clarified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
