[GitHub] [kafka] cadonna commented on a diff in pull request #13927: KAFKA-10199: Enable state updater by default

[via GitHub]

cadonna commented on code in PR #13927:
URL: https://github.com/apache/kafka/pull/13927#discussion_r1246546787


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -368,8 +368,11 @@ public static StreamThread create(final TopologyMetadata 
topologyMetadata,
 
         final ThreadCache cache = new ThreadCache(logContext, cacheSizeBytes, 
streamsMetrics);
 
-        final boolean stateUpdaterEnabled =
-            InternalConfig.getBoolean(config.originals(), 
InternalConfig.STATE_UPDATER_ENABLED, false);
+        final boolean stateUpdaterEnabled = InternalConfig.getBoolean(
+                config.originals(),
+                InternalConfig.STATE_UPDATER_ENABLED,
+                InternalConfig.STATE_UPDATER_ENABLED_DEFAULT
+        );

Review Comment:
   Enabling the state updater by default.



##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -551,7 +554,11 @@ public StreamThread(final Time time,
 
         this.numIterations = 1;
         this.eosEnabled = eosEnabled(config);
-        this.stateUpdaterEnabled = 
InternalConfig.getBoolean(config.originals(), 
InternalConfig.STATE_UPDATER_ENABLED, false);
+        this.stateUpdaterEnabled = InternalConfig.getBoolean(
+                config.originals(),
+                InternalConfig.STATE_UPDATER_ENABLED,
+                InternalConfig.STATE_UPDATER_ENABLED_DEFAULT
+        );

Review Comment:
   Enabling the state updater by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org