[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

[via GitHub]

jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1246997020


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -537,8 +538,35 @@ public void testUpdateSubscriptionMetadata() {
             consumerGroup.computeSubscriptionMetadata(
                 null,
                 null,
-                image
+                image.topics()
             )
         );
     }
+
+    @Test
+    public void testMetadataRefreshDeadline() {

Review Comment:
   should this also test `requestMetadataRefresh`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org