[ 
https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738744#comment-17738744
 ] 

Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:01 PM:
----------------------------------------------------------------

Thanks, [~ddufour1a] for raising this. The backward compatibility mentioned in 
the KIP accounted only for using the default separator configuration and didn't 
address the usage custom separator (my mistake here). [~ChrisEgerton] I think 
having `{{{}replication.policy.internal.topic.separator.enabled` is a good 
option.{}}}

{{{}We can also update the backward compatibility section in KIP-690 to ask 
users to override the `ReplicationPolicy.{}}}offsetSyncsTopic`and 
`ReplicationPolicy.checkpointsTopic` methods to use old topics if they still 
want to use the old internal topics or delete them so they are aware of this 
issue.


was (Author: omnia_h_ibrahim):
Thanks, [~ddufour1a] for raising this. The backward compatibility mentioned in 
the KIP accounted only for using the default separator configuration and didn't 
address the usage custom separator (my mistake here). [~ChrisEgerton] I think 
having `{{{}replication.policy.internal.topic.separator.enabled` is a good 
option.{}}}

{{{}We can also update the backward compatibility section in KIP-690 to ask 
customers to override the `ReplicationPolicy.{}}}offsetSyncsTopic`and 
`ReplicationPolicy.checkpointsTopic` methods to use old topics if they still 
want to use the old internal topics or delete them so they are aware of this 
issue.

> Mirror Maker 2 - KIP690 backward compatibility
> ----------------------------------------------
>
>                 Key: KAFKA-15102
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15102
>             Project: Kafka
>          Issue Type: Bug
>          Components: mirrormaker
>    Affects Versions: 3.1.0
>            Reporter: David Dufour
>            Priority: Major
>
> According to KIP690, "When users upgrade an existing MM2 cluster they don’t 
> need to change any of their current configuration as this proposal maintains 
> the default behaviour for MM2."
> Now, the separator is subject to customization.
> As a consequence, when an MM2 upgrade is performed, if the separator was 
> customized with replication.policy.separator, the name of this internal topic 
> changes. It then generates issues like:
> Caused by: java.util.concurrent.ExecutionException: 
> org.apache.kafka.common.errors.InvalidTopicException: Topic 
> 'mm2-offset-syncs_bkts28_internal' collides with existing topics: 
> mm2-offset-syncs.bkts28.internal
> It has been observed that the replication can then be broken sometimes 
> several days after the upgrade (reason not identified). By deleting the old 
> topic name, it recovers.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to