C0urante commented on code in PR #13939:
URL: https://github.com/apache/kafka/pull/13939#discussion_r1247916426
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceCompleted() {
if (assignment.failed()) {
needsRejoin = true;
if (isLeader()) {
- log.warn("Join group completed, but assignment failed and we
are the leader. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and
we are the leader. Reading to end of config and retrying.");
needsReadToEnd = true;
} else if (configState.offset() < assignment.offset()) {
- log.warn("Join group completed, but assignment failed and we
lagging. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and
we are lagging. Reading to end of config and retrying.");
Review Comment:
I think the only change we need here is "we are lagging"; "assignment" is
fine without a preceeding "the".
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceCompleted() {
if (assignment.failed()) {
needsRejoin = true;
if (isLeader()) {
- log.warn("Join group completed, but assignment failed and we
are the leader. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and
we are the leader. Reading to end of config and retrying.");
needsReadToEnd = true;
} else if (configState.offset() < assignment.offset()) {
- log.warn("Join group completed, but assignment failed and we
lagging. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and
we are lagging. Reading to end of config and retrying.");
Review Comment:
I think the only change we need here is "we are lagging"; "assignment" is
fine without a preceding "the".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
