[GitHub] [kafka] C0urante commented on a diff in pull request #13913: KAFKA-15119:Support incremental syncTopicAcls in MirrorSourceConnector

[via GitHub]

C0urante commented on code in PR #13913:
URL: https://github.com/apache/kafka/pull/13913#discussion_r1248004857


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -582,12 +583,20 @@ void incrementalAlterConfigs(Map<String, Config> 
topicConfigs) {
     }
 
     private void updateTopicAcls(List<AclBinding> bindings) {
-        log.trace("Syncing {} topic ACL bindings.", bindings.size());
-        targetAdminClient.createAcls(bindings).values().forEach((k, v) -> 
v.whenComplete((x, e) -> {
-            if (e != null) {
-                log.warn("Could not sync ACL of topic {}.", 
k.pattern().name(), e);
-            }
-        }));
+        Set<AclBinding> addBindings = new HashSet<>();
+        addBindings.addAll(bindings);

Review Comment:
   Nit: can simplify
   ```suggestion
           Set<AclBinding> addBindings = new HashSet<>(bindings);
   ```



##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -582,12 +583,20 @@ void incrementalAlterConfigs(Map<String, Config> 
topicConfigs) {
     }
 
     private void updateTopicAcls(List<AclBinding> bindings) {
-        log.trace("Syncing {} topic ACL bindings.", bindings.size());
-        targetAdminClient.createAcls(bindings).values().forEach((k, v) -> 
v.whenComplete((x, e) -> {
-            if (e != null) {
-                log.warn("Could not sync ACL of topic {}.", 
k.pattern().name(), e);
-            }
-        }));
+        Set<AclBinding> addBindings = new HashSet<>();
+        addBindings.addAll(bindings);
+        addBindings.removeAll(knownTopicAclBindings);
+        if (!addBindings.isEmpty()) {
+            log.info("Syncing new found {} topic ACL bindings.", 
addBindings.size());
+            targetAdminClient.createAcls(addBindings).values().forEach((k, v) 
-> v.whenComplete((x, e) -> {
+                if (e != null) {
+                    log.warn("Could not sync ACL of topic {}.", 
k.pattern().name(), e);
+                }
+            }));
+            knownTopicAclBindings = bindings;

Review Comment:
   ```suggestion
               knownTopicAclBindings =  new HashSet<>(bindings);
   ```



##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -582,12 +583,20 @@ void incrementalAlterConfigs(Map<String, Config> 
topicConfigs) {
     }
 
     private void updateTopicAcls(List<AclBinding> bindings) {
-        log.trace("Syncing {} topic ACL bindings.", bindings.size());
-        targetAdminClient.createAcls(bindings).values().forEach((k, v) -> 
v.whenComplete((x, e) -> {
-            if (e != null) {
-                log.warn("Could not sync ACL of topic {}.", 
k.pattern().name(), e);
-            }
-        }));
+        Set<AclBinding> addBindings = new HashSet<>();
+        addBindings.addAll(bindings);
+        addBindings.removeAll(knownTopicAclBindings);

Review Comment:
   My IDE nagged me about possible slow performance for invoking 
`Set::removeAll` with a `List` as an argument. Some research led to [this 
fascinating blog 
post](https://codeblog.jonskeet.uk/2010/07/29/there-s-a-hole-in-my-abstraction-dear-liza-dear-liza/).
   
   I think the scenario described there isn't likely to impact us frequently, 
but just in case, do you think we can change `knownTopicAclBindings` from a 
`List` to a `Set`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org