jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248102033
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
assertTrue(group.hasMetadataExpired(time.milliseconds()));
assertEquals(time.milliseconds() + 1000,
group.metadataRefreshDeadline().deadlineMs);
assertEquals(group.groupEpoch() + 1,
group.metadataRefreshDeadline().epoch);
+
+ // Set the refresh deadline.
+ group.setMetadataRefreshDeadline(time.milliseconds() + 1000,
group.groupEpoch());
Review Comment:
I thought in the case the write is lost, we have the higher epoch in the
DeadlineAndEpoch and that would signal us to continue to refresh. However, in
this case, you are saying we would go back and epoch and decide not to try to
refresh anymore. Is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
