divijvaidya commented on code in PR #12685:
URL: https://github.com/apache/kafka/pull/12685#discussion_r1250943986
##########
clients/src/main/java/org/apache/kafka/common/serialization/ByteBufferSerializer.java:
##########
@@ -50,4 +51,29 @@ public byte[] serialize(String topic, ByteBuffer data) {
data.flip();
return Utils.toArray(data);
}
+
+ /**
+ * Note that this method will modify the position and limit of the input
ByteBuffer.
+ *
+ * @param topic topic associated with data
+ * @param data typed data
+ * @return serialized ByteBuffer
+ */
+ @Override
+ public ByteBuffer serializeToByteBuffer(String topic, ByteBuffer data) {
Review Comment:
No, actually number 1 is still missing. See my comment at
https://github.com/apache/kafka/pull/12685#discussion_r1250526734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
