[ https://issues.apache.org/jira/browse/KAFKA-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740369#comment-17740369 ]
Ezio Xie edited comment on KAFKA-15148 at 7/6/23 1:55 AM: ---------------------------------------------------------- I run "./gradlew unitTest" in local and I get html summary with these integration tests (I searched them by key word 'integration'): core (scala): kafka.coordinator.transaction.ProducerIdsIntegrationTest kafka.server.MetadataVersionIntegrationTest kafka.zk.ZkMigrationIntegrationTest connect: org.apache.kafka.connect.integration.StartAndStopCounterTest org.apache.kafka.connect.integration.StartAndStopLatchTest clients: org.apache.kafka.clients.admin.internals.AllBrokersStrategyIntegrationTest I have several questions here: 1. There is an annotation "@Category(IntegrationTest.class)" on "NamedTopologyIntegrationTest" and "QueryableStateIntegrationTest", as it is excluded in "task unitTest" so this tests will not be run as a part of "./gradlew unitTest". These two tests are just examples, right? 2. Is it ok that I use the key word "integration" to search the integration tests? 3. What needs to be done is add "@Category(IntegrationTest.class)" on above tasks, and make sure they are exclueded by "./gradlew unitTest", is it right? 4. To scala tests, I do not need to change them since they cannot be added any annotation to exclude, right? was (Author: JIRAUSER290463): I run "./gradlew unitTest" in local and I get html summary with these integration tests (I searched them by key word 'integration'): core (scala): kafka.coordinator.transaction.ProducerIdsIntegrationTest kafka.server.MetadataVersionIntegrationTest kafka.zk.ZkMigrationIntegrationTest connect: org.apache.kafka.connect.integration.StartAndStopCounterTest org.apache.kafka.connect.integration.StartAndStopLatchTest clients: org.apache.kafka.clients.admin.internals.AllBrokersStrategyIntegrationTest I have several questions here: 1. There is an annotation "@Category(IntegrationTest.class)" on "NamedTopologyIntegrationTest" and "QueryableStateIntegrationTest", as it is excluded in "task unitTest" so this tests will not be run as a part of "./gradlew unitTest". These two tests are just examples, right?{*}{*} 2. Is it ok that I use the key word "integration" to search the integration tests? 3. What needs to be done is add "@Category(IntegrationTest.class)" on above tasks, and make sure they are exclueded by "./gradlew unitTest", is it right? 4. To scala tests, I do not need to change them since they cannot be added any annotation to exclude, right? > Some integration tests are running as unit tests > ------------------------------------------------ > > Key: KAFKA-15148 > URL: https://issues.apache.org/jira/browse/KAFKA-15148 > Project: Kafka > Issue Type: Test > Components: unit tests > Reporter: Divij Vaidya > Assignee: Ezio Xie > Priority: Minor > Labels: newbie > > *This is a good item for a newcomer into Kafka code base to pick up* > > When we run `./gradlew unitTest`, it is supposed to run all unit tests. > However, we are running some integration tests as part of which makes the > overall process of running unitTest take longer than expected. > Example of such tests: > > :streams:unitTest > Executing test > > org.apache...integration.NamedTopologyIntegrationTest > > :streams:unitTest > Executing test > > org.apache...integration.QueryableStateIntegrationTest > After this task, we should not run the these tests as part of `./gradlew > unitTest`, instead they should be run as part of `./gradlew integrationTest`. > As part of acceptance criteria, please add the snapshot of html summary > generated to verify that these tests are indeed running as part of > integrationTest. -- This message was sent by Atlassian Jira (v8.20.10#820010)