jolshan commented on code in PR #13961:
URL: https://github.com/apache/kafka/pull/13961#discussion_r1254995855
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorTimer.java:
##########
@@ -16,12 +16,26 @@
*/
package org.apache.kafka.coordinator.group.runtime;
+import org.apache.kafka.common.KafkaException;
+
+import java.util.List;
import java.util.concurrent.TimeUnit;
/**
* An interface to schedule and cancel operations.
*/
-public interface Timer {
+public interface CoordinatorTimer<U> {
+ /**
+ * Generates the records needed to implement this timeout write operation.
In general,
Review Comment:
Could we maybe give an example of a timeout operation here? I had a little
trouble conceptualizing this.
22/N gave examples -- ie we need to fence a group after a certain amount of
time that really made me understand better.
(I think reviewing the metadata refresh pr -- which had a different
mechanism for stale data confused me a bit too, but I now understand why that
can happen on the next heartbeat and why this should be done with a timer)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
