fvaleri commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1257293747
########## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandOptions.java: ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import joptsimple.ArgumentAcceptingOptionSpec; +import joptsimple.OptionSpecBuilder; +import org.apache.kafka.server.util.CommandDefaultOptions; + +public class ReassignPartitionsCommandOptions extends CommandDefaultOptions { + // Actions + private final OptionSpecBuilder verifyOpt; + private final OptionSpecBuilder generateOpt; + private final OptionSpecBuilder executeOpt; + private final OptionSpecBuilder cancelOpt; + private final OptionSpecBuilder listOpt; + + // Arguments + private final ArgumentAcceptingOptionSpec<String> bootstrapServerOpt; Review Comment: For consistency with the other tools, I would use the `OptionSpec` superclass. ########## tools/src/main/java/org/apache/kafka/tools/reassign/TerseReassignmentFailureException.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import org.apache.kafka.common.KafkaException; + +/** + * An exception thrown to indicate that the command has failed, but we don't want to + * print a stack trace. + */ +public class TerseReassignmentFailureException extends KafkaException { Review Comment: Do we really need this? Can't we simply use `TerseException`? ########## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandOptions.java: ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import joptsimple.ArgumentAcceptingOptionSpec; +import joptsimple.OptionSpecBuilder; +import org.apache.kafka.server.util.CommandDefaultOptions; + +public class ReassignPartitionsCommandOptions extends CommandDefaultOptions { + // Actions + private final OptionSpecBuilder verifyOpt; Review Comment: For consistency with the other tools, I would use the `OptionSpec` superclass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
