hudeqi commented on PR #13992: URL: https://github.com/apache/kafka/pull/13992#issuecomment-1631789763
> Thanks for the fix @hudeqi ! I was wondering if you had plans to address this problem/warning elsewhere in the codebase? I did a global search for the `removeAll` method of set in the codebase. There are indeed many `set.removeAll(list)`, but this usage may have performance problems only when there are many collection elements. At least in the connect module there is nothing extra except that mentioned in this PR. In other modules, there may be this [one](https://github.com/apache/kafka/blob/f3ee9ff90ff107942280fb0c4bd83e7ebc5c062c/storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java#L177) that needs to be optimized to meet these conditions, which may not be suitable for mentioning in this PR (belonging to the MM2 tag). @gharris1727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
