[ 
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742406#comment-17742406
 ] 

Divij Vaidya commented on KAFKA-14953:
--------------------------------------

Hey [~abhijeetkumar] [~jeqo] 
We should not change the public facing interfaces defined in the KIP after it 
has been voted and accepted. I observed that we are changing a few metric name 
such as 
[https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=97554472&selectedPageVersions=364&selectedPageVersions=363]
 but that would break the contract defined by the KIP. Let's create new KIPs 
for changes in the metrics where we can deprecate old ones and create new ones.

> Add metrics for tiered storage
> ------------------------------
>
>                 Key: KAFKA-14953
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14953
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Divij Vaidya
>            Assignee: Abhijeet Kumar
>            Priority: Minor
>
> Not just for expired fetch. We also need to add all the metrics described in 
> KIP-405
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-405%3A+Kafka+Tiered+Storage#KIP405:KafkaTieredStorage-NewMetrics
>  
> ref: [https://github.com/apache/kafka/pull/13535#discussion_r1180286031] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to